[ 
https://issues.apache.org/jira/browse/HDFS-13643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496721#comment-16496721
 ] 

Daryn Sharp commented on HDFS-13643:
------------------------------------

It's a nice POC but not implementing security is a non-starter....

I think this can initially be done in a much simpler way that doesn't discard 
any functionality (ex. security and service class is immediately evident, I'm 
sure there's more) and doesn't create a divergent ipc client to maintain.
 * Add an optional {{FutureTask}} to {{Client.Call}}.
 * {{Call#setRpcResponse}} delegates to {{FutureTask#set}}
 * {{Call#setException}} delegates to {{FutureTask#setException}}
 * {{Client#getRpcResponse}} just invokes {{FutureTask#get}}.
 * {{FutureTask#done}} method can be used for callbacks.

Or simpler yet, just make {{Client.Call}} extend {{FutureTask}} so the client 
code doesn't have conditionals for whether the future is defined.

> Implement basic async rpc client
> --------------------------------
>
>                 Key: HDFS-13643
>                 URL: https://issues.apache.org/jira/browse/HDFS-13643
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ipc
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>         Attachments: HDFS-13643.patch
>
>
> Implement the basic async rpc client so we can start working on the DFSClient 
> implementation ASAP.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to