[
https://issues.apache.org/jira/browse/HDDS-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498999#comment-16498999
]
Ajay Kumar commented on HDDS-100:
---------------------------------
[~xyao] thanks for review, updated patch to address comment.
{quote}This brought in the bouncycastle which other sub-project poms exclude to
avoid transitive dependency. (E.g., hadoop-auth and hadoop-common). Can you
confirm if bcprov-jdk15on is a safe dependency to add here?{quote}
this will not add any dependencies in hadoop-auth or hadoop-common, but all sub
modules of hadoop-hdds will have it.
{quote}Line 173: should we check permission and set only if it is
different?{quote}
Checking permission first and than changing it if required will result in 1 or
2 file operations. (current approach involves one file operations)
{quote}Do we expect the caller to handle the permission change failures?{quote}
IMO if for some reason we can't create base dir its better to throw exception
and let caller handle it.
{quote} Can we add a LOG.error here and throw more specific IOE like other
places?{quote}
done
{quote}Line 204-207: do we support password protected PKCS#8 or other
format?{quote}
Current patch doesn't support it. If we agree to support passphrase than we
have to address few questions like where/how to store it?
> SCM CA: generate public/private key pair for SCM/OM/DNs
> -------------------------------------------------------
>
> Key: HDDS-100
> URL: https://issues.apache.org/jira/browse/HDDS-100
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Ajay Kumar
> Priority: Major
> Fix For: 0.3.0
>
> Attachments: HDDS-100-HDDS-4.00.patch, HDDS-100-HDDS-4.01.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
