[
https://issues.apache.org/jira/browse/HDFS-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067666#comment-13067666
]
Uma Maheswara Rao G commented on HDFS-2161:
-------------------------------------------
Hi Nicholas,
I have reviewd this patch.
I have checked the referances in Mapreduce & Hbase as well.
In Above comment, you already mentioned that MapReduce is using that
DFSClient.stringifyToken.
{code}
LOG.debug("Submitting with " +
DFSClient.stringifyToken((Token<org.apache.hadoop.hdfs.security.token.delegation.DelegationTokenIdentifier>)
token));
{code}
can we raise one Jira for that in MapReduce?
+1 Patch looks good to me.
We should co-ordinate to comitt both(mapred + hdfs issue) at same time to
avoid the breakage in Mapreduce.
small nits,
1. i did not see any big advantage by moving the random object, other than the
object creations. If any big advantage then we will plan ,to move it to common
utils. So, that we can change in mapred side also to use :-).
2. Now stringifyToken moved to DelegationTokenIdentifier, looks Mepred also has
one DelegationTokenIdentifier please check. Can we think some common place for
it?
We can check this nits from Mepreduce issue.
> Move utilities to DFSUtil
> -------------------------
>
> Key: HDFS-2161
> URL: https://issues.apache.org/jira/browse/HDFS-2161
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer, data-node, hdfs client, name-node, security
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h2161_20110718.patch
>
>
> Utilities include
> - {{createNamenode(..)}}, {{createClientDatanodeProtocolProxy(..)}};
> - {{stringifyToken(..)}}; and
> - {{Random}} object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
