[
https://issues.apache.org/jira/browse/HDDS-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500754#comment-16500754
]
Hanisha Koneru commented on HDDS-140:
-------------------------------------
Thanks for the review, [~xyao].
{quote}In VolumeSet.java
Line 178-182: we are putting a volume of non_existent state into a failed
volume map. Should we keep the volume in failed state during the
volumeInfo.failVolume()?
{quote}
In {{VolumeSet#failVolume}}, we set the state as FAILED and put the volume in
{{failedVolumeMap}}.
{code:java}
# Lines 178-182
volumeInfo.failVolume();
volumeMap.remove(dirPath);
volumeStateMap.get(volumeInfo.getStorageType()).remove(volumeInfo);
failedVolumeMap.put(dirPath, volumeInfo);{code}
When shutting down the volume, if the volume was active, we change its state to
NON_EXISTENT and remove it from volumeMap. If the volume to be removed is in
failed state, we remove it from failedVolumeMap.
We are not putting a volume in NON_EXISTENT state into {{failedVolumeMap}}. I
will update the stated of the failed volume to non_existent before removing it
from failedVolumeMap.
> Add DU usage to VolumeInfo
> --------------------------
>
> Key: HDDS-140
> URL: https://issues.apache.org/jira/browse/HDDS-140
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-140-HDDS-48.001.patch
>
>
> We need to start a DU thread per VolumeInfo to get the usage info.
> Each VolumeInfo object will wrap a VolumeUsage object to collect usage info.
> The proposed VolumeUsage class will replace ContainerStorageLocation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
