[ 
https://issues.apache.org/jira/browse/HDFS-13607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501070#comment-16501070
 ] 

Konstantin Shvachko commented on HDFS-13607:
--------------------------------------------

Hey [~xkrogen].
# Did you look at {{LightWeightCache}} / {{LightWeightGSet}}? It worked better 
for us in the past than {{ConcurrentHashMap}} or {{TreeMap}}.
# Would {{lowestTxnId}} sound better than {{initialTxnId}}? I understand it's 
the opposite to your {{highestTxnId}}. Otherwise it is hard to distinguish 
between "initial" and "starting" TxnId.
# I think it is better to convert comments to private members into JavaDoc 
comments. It is not public, so it wont mater for documentations, but it still 
good to see definitions when hoovering over the variables in IDE.
# Do we need {{serialVersionUID}} for {{CacheMissException}}?

> [Edit Tail Fast Path Pt 1] Enhance JournalNode with an in-memory cache of 
> recent edit transactions
> --------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-13607
>                 URL: https://issues.apache.org/jira/browse/HDFS-13607
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, journal-node
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>            Priority: Major
>         Attachments: HDFS-13607-HDFS-12943.000.patch, 
> HDFS-13607-HDFS-12943.001.patch, HDFS-13607-HDFS-12943.002.patch
>
>
> See HDFS-13150 for full design.
> This JIRA is to add the in-memory cache of recent edit transactions on the 
> JournalNode. This JIRA does not include accesses to this cache.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to