[ 
https://issues.apache.org/jira/browse/HDDS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501134#comment-16501134
 ] 

Mukul Kumar Singh commented on HDDS-123:
----------------------------------------

Thanks for working on this [~bharatviswa]. The v4 patch looks good to me. One 
minor comment. 

TestContainerSet:34, Please expand the wildcard import to add only the required 
classes.

Rest the v4 patch looks good to me. +1, after the above comment is addressed.

> ContainerSet class to manage ContainerMap 
> ------------------------------------------
>
>                 Key: HDDS-123
>                 URL: https://issues.apache.org/jira/browse/HDDS-123
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-123-HDDS-48.00.patch, HDDS-123-HDDS-48.01.patch, 
> HDDS-123-HDDS-48.02.patch, HDDS-123-HDDS-48.03.patch, 
> HDDS-123-HDDS-48.04.patch
>
>
> Create a ContainerSet class, which manages containerMap.
> Previously container map is in ContainerManagerImpl, with refactoring work it 
> should be moved to ContainerSet. 
> This class should handle add/get/remove container from containerMap.
> And also now it should handle containerReport.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to