[ 
https://issues.apache.org/jira/browse/HDDS-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501353#comment-16501353
 ] 

Nanda kumar commented on HDDS-147:
----------------------------------

Thanks [~arpitagarwal] for working on this. Overall the patch looks good to me, 
some minor comments

*GettingStarted.md*
 * Line:69 The tar file name should be 
{{hadoop-dist/target/ozone-${project.version}.tar.gz}}
 * Line:172 {{ozone.scm.datanode.id}} is a mandatory setting, which is 
mentioned as optional.
 * Line:196 {{Ozonehandler}} should be {{OzoneClient}}
 * {{dfs.datanode.plugins}} is explained twice, Line:118 and Line:205. Can we 
consolidate them?
 * Sample {{ozone-site.xml}} is missing {{ozone.scm.datanode.id}}.

*CommandShell.md*
 * Line:30
{quote}The `port` specified in command should match the port mentioned in the 
...
{quote}
The {{oz}} command syntax that is given in the doc doesn't mention anything 
about the port. Should we explain different formats in which we can run a 
command? Follow up jira can be created to add it.

 * Line:49, 58, 80 & 115 - There is an additional ({{`}}) at the end of the 
line.
 * Line:78: typo
 {{"It can also be used by any user to list volumes their own volumes"}} --> 
 {{"It can also be used by any user to list their own volumes"}} 
or 
 {{"It can also be used by any user to list the volumes they own"}}

 
{quote}I don't know how to run Ozone separately without the HDFS DataNode. 
Could you please clarify that?
{quote}
For this we need HDDS-94, this will introduce the option to start 
{{hdds-datanode}} (without hdfs modules)

> Update Ozone site docs
> ----------------------
>
>                 Key: HDDS-147
>                 URL: https://issues.apache.org/jira/browse/HDDS-147
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: document
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>            Priority: Major
>              Labels: documentation
>         Attachments: HDDS-147.01.patch, HDDS-147.02.patch, HDDS-147.03.patch
>
>
> Ozone site docs need a few updates to the command syntax.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to