[
https://issues.apache.org/jira/browse/HDFS-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501355#comment-16501355
]
Yiqun Lin edited comment on HDFS-13641 at 6/5/18 7:07 AM:
----------------------------------------------------------
Thanks for updating the patch, [~csun]!
* As I see we have added some new metrics, can we update the unit test as well?
* Can we move the line {{NameNode.getNameNodeMetrics().addEditLogTailTime(
Time.monotonicNow() - startTime);}} before {{namesystem.cpUnlock();}}? This
will be the accurate time for the metrics.
was (Author: linyiqun):
Thanks for updating the patch, [~csun]! As I see we have added some new
metrics, can we update the unit test as well?
> Add metrics for edit log tailing
> ---------------------------------
>
> Key: HDFS-13641
> URL: https://issues.apache.org/jira/browse/HDFS-13641
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: metrics
> Reporter: Chao Sun
> Assignee: Chao Sun
> Priority: Major
> Attachments: HDFS-13641-HDFS-12943.000.patch, HDFS-13641.000.patch,
> HDFS-13641.001.patch, HDFS-13641.002.patch
>
>
> We should add metrics for each iteration of edit log tailing, including 1) #
> of edits loaded, 2) time spent in select input edit stream, 3) time spent in
> loading the edits, 4) interval between the iterations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
