[ https://issues.apache.org/jira/browse/HDDS-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504063#comment-16504063 ]
genericqa commented on HDDS-146: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 38s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 12 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 29m 47s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 19s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 22s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 17s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 14s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 14s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 2s{color} | {color:green} The patch generated 0 new + 2 unchanged - 2 fixed = 2 total (was 4) {color} | | {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 14s{color} | {color:green} There were no new shelldocs issues. {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 7 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 12m 24s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 16s{color} | {color:green} acceptance-test in the patch passed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 27s{color} | {color:red} The patch generated 10 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 58m 12s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd | | JIRA Issue | HDDS-146 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12926805/HDDS-146.004.patch | | Optional Tests | asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall shadedclient xml | | uname | Linux a50c0bb03e0d 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / db81f85 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_171 | | shellcheck | v0.4.6 | | whitespace | https://builds.apache.org/job/PreCommit-HDDS-Build/257/artifact/out/whitespace-tabs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDDS-Build/257/testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-HDDS-Build/257/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 336 (vs. ulimit of 10000) | | modules | C: hadoop-ozone/acceptance-test U: hadoop-ozone/acceptance-test | | Console output | https://builds.apache.org/job/PreCommit-HDDS-Build/257/console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Refactor the structure of the acceptance tests > ---------------------------------------------- > > Key: HDDS-146 > URL: https://issues.apache.org/jira/browse/HDDS-146 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Reporter: Elek, Marton > Assignee: Elek, Marton > Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-146.001.patch, HDDS-146.002.patch, > HDDS-146.004.patch > > > I started to fix the packaging the ozone file system which requires > additional acceptance tests. > The original acceptance test is added when it was only one single file but > (fortunately) now we have multiple files and multiple tests and ozonefs > requires even more. > To make it easier to handle multplie acceptance tests I propose some changes > on the projects structure. This patch includes the following changes: > # all the start/stop/check common keywords are moved out the a common > library file (commonlib.robot). All the existing files are simplified. > # ozone-shell tests are simplified with using parametrized tests. We don't > need to repeat the same steps multiple times. > # The directories in the projects are simplified. Both compose file and > robot files are in the same directory. The basedir is handled from the robot > files. Now it's easier to run the tests localy (go to the dir and do a simple > call 'robot basic.robot') or start the containers (use docker-compose from > the base directory) > # I adjusted the logging (warning about the missing native library is not > required) > # Decreased the heartbeat intervall (to make the tests faster) > # I improved the ozone-shell tests with adding a few additional checks. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org