[
https://issues.apache.org/jira/browse/HDDS-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505350#comment-16505350
]
Xiaoyu Yao edited comment on HDDS-100 at 6/7/18 9:57 PM:
---------------------------------------------------------
Thanks [~ajayydv] for the update. Patch v3 looks good to me. There are two more
issues:
# There is a CP bug in HDDSKeyPEMWriter#writeKey line 181 where the
privateKeyFile should be publicKeyFile. The unit test failure should be fixed
with that.
# HDDSKeyPEMWriter.java line 177/181, we should use fixed
StandardCharsets.UTF_8 (preferably defined as a static final in this class)
consistently to avoid any future localization change issues.
was (Author: xyao):
Thanks [~ajayydv] for the update. There is a bug in HDDSKeyPEMWriter#writeKey
line 181 where the privateKeyFile should be publicKeyFile. The unit test
failure should be fixed with that.
> SCM CA: generate public/private key pair for SCM/OM/DNs
> -------------------------------------------------------
>
> Key: HDDS-100
> URL: https://issues.apache.org/jira/browse/HDDS-100
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Ajay Kumar
> Priority: Major
> Fix For: 0.3.0
>
> Attachments: HDDS-100-HDDS-4.00.patch, HDDS-100-HDDS-4.01.patch,
> HDDS-100-HDDS-4.02.patch, HDDS-100-HDDS-4.03.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
