[
https://issues.apache.org/jira/browse/HDDS-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506405#comment-16506405
]
Xiaoyu Yao commented on HDDS-59:
--------------------------------
Thanks [~msingh] for working on this. The patch looks pretty good to me. I just
have few minor comments:
KsmKeyInfo.java
Line 126-137: this can be consolidated with the same loop by starting from the
back, i.e., locationInfo.size() -1 and check if the blockID matches.
Line 40/101: Do we need to update the dataSize after the commit the block
length change? Or we expect the caller of the updateBlockLength() handle that
separately?
KSMMetrics.java
Line 84/241/255/461/466: can we change this to numCommitBlockCallFails for
consistency?
Can we add some unit tests that coves the new commitBlock APIs?
> Ozone client should update blocksize in KSM for sub-block writes
> ----------------------------------------------------------------
>
> Key: HDDS-59
> URL: https://issues.apache.org/jira/browse/HDDS-59
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Client
> Affects Versions: 0.2.1
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-59.001.patch
>
>
> Currently ozone client allocates block of the required length from SCM
> through KSM.
> However it might happen due to error cases or because of small writes that
> the allocated block is not completely written.
> In these cases, client should update the KSM with the length of the block.
> This will help in error cases as well as cases where client does not write
> the complete block to Ozone.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
