[ 
https://issues.apache.org/jira/browse/HDDS-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507736#comment-16507736
 ] 

Nanda kumar commented on HDDS-111:
----------------------------------

Thanks [~ljain] for working on this.

Handling of retrying from a client should depend on the error-code/exception 
that is returned from the server, we should have a list of retriable and 
non-retriable errors, based on which the client has to decide. With this patch 
even if the KSM Service is down the client will keep retrying which is not what 
we want.

We can handle all the client retry logic in separate jira(s).

*DistributedStorageHandler.java*
The refactoring of using {{HddsClientUtils}} over {{OzoneUtils}} is incomplete, 
we still have {{OzoneUtils}} usages.

> Include tests for Rest Client in TestVolume and TestBucket
> ----------------------------------------------------------
>
>                 Key: HDDS-111
>                 URL: https://issues.apache.org/jira/browse/HDDS-111
>             Project: Hadoop Distributed Data Store
>          Issue Type: Task
>          Components: Ozone Client
>            Reporter: Lokesh Jain
>            Assignee: Lokesh Jain
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-111.001.patch, HDDS-111.002.patch
>
>
> Currently TestVolume and TestBucket only include tests for Rpc client. This 
> Jira aims to add tests for Rest Client as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to