[ 
https://issues.apache.org/jira/browse/HDDS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508471#comment-16508471
 ] 

Hanisha Koneru commented on HDDS-136:
-------------------------------------

Thanks for the patch [~bharatviswa].

LGTM overall. Just one suggestion - It might be good to rename 
{{containerMetaDataPath}} to something shorter like {{metadataPath}}. 

+1 pending Jenkins.

> Rename dbPath,containerFilePath
> -------------------------------
>
>                 Key: HDDS-136
>                 URL: https://issues.apache.org/jira/browse/HDDS-136
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-136-HDDS-48.00.patch, HDDS-136-HDDS-48.01.patch
>
>
> In KeyValueContainerData, we need to update 
> dbPath as - containerMetaDataPath (As it holds rockdb/leveldb file and 
> .container file)
> chunksLocation - location of the chunk files
>  
> It will be cleaner if we rename these variables and it will be easy for 
> reading the code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to