[
https://issues.apache.org/jira/browse/HDFS-13566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508613#comment-16508613
]
Chen Liang commented on HDFS-13566:
-----------------------------------
Thanks for the review [~ajayydv]! Post v003 patch to address comments, also fix
two failed unit tests, the other test fails are unrelated.
bq. L3156-61 wrap call to each listener in try catch to avoid skipping stop
call on remaining listeners due to error/exception in one listener.
actually, interrupt() and doStop() don't throw any exception, so there is
nothing here to catch.
bq. NameNode#getNameNodeAddressHostAdditionalPortString ...
currently it is getting the iterator on a Set and return the first element from
the iterator. Since the iterator has no particular order on a set, this is
effectively already returning a random one from the set. I've elaborated with
comments to make this more clear.
bq. Rename#getNameNodeAddressHostAdditionalPortString ...
Fixed.
bq. Namenode#getAdditionalNameNodeAddresses In addition to this function shall
we have a additional wrapper function
did you mean, not only returning the additional addresses, but have a wrapper
to also include and return the original one?
bq. MiniDFSCluster getNameNodeAdditionalPort/getNameNodeAdditionalPort doesn't
seems to return random port...
Fixed
bq. TestDistributedFileSystem#testDFSClientNNAdditionalPort: Shall we add test
case for multiple additional rpc ports. ...
Will do, still working on exposing more clear configuration keys, will add this
test along with it in next patch.
> Add configurable additional RPC listener to NameNode
> ----------------------------------------------------
>
> Key: HDFS-13566
> URL: https://issues.apache.org/jira/browse/HDFS-13566
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ipc
> Reporter: Chen Liang
> Assignee: Chen Liang
> Priority: Major
> Attachments: HDFS-13566.001.patch, HDFS-13566.002.patch,
> HDFS-13566.003.patch
>
>
> This Jira aims to add the capability to NameNode to run additional
> listener(s). Such that NameNode can be accessed from multiple ports.
> Fundamentally, this Jira tries to extend ipc.Server to allow configured with
> more listeners, binding to different ports, but sharing the same call queue
> and the handlers. Useful when different clients are only allowed to access
> certain different ports. Combined with HDFS-13547, this also allows different
> ports to have different SASL security levels.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
