Xiaoyu Yao commented on HDDS-159:

Thanks [~ljain] for working on it. The patch looks good to me overall. I just 
have few comments:



Line 370-373: the response should be fully consumed before volume list parsing 
like below:


HttpEntity response=executeHttpRequest(httpGet);


ListVolumes volumeList=




Line 596-599, Line 771-773: same as above.



Line 105: logic below needs to be removed to improve coverage.









Line 292: same as above.



Line 231/318: same as above.

> RestClient: Implement list operations for volume, bucket and keys
> -----------------------------------------------------------------
>                 Key: HDDS-159
>                 URL: https://issues.apache.org/jira/browse/HDDS-159
>             Project: Hadoop Distributed Data Store
>          Issue Type: Task
>          Components: Ozone Client
>            Reporter: Lokesh Jain
>            Assignee: Lokesh Jain
>            Priority: Major
>             Fix For: 0.2.1
>         Attachments: HDDS-159.001.patch
> Currently RestClient does not provide implementation for list volume, list 
> buckets and list keys. This Jira aims to add the implementation and necessary 
> tests for the same.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to