[ 
https://issues.apache.org/jira/browse/HDDS-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510498#comment-16510498
 ] 

Bharat Viswanadham commented on HDDS-155:
-----------------------------------------

 Hi [~hanishakoneru]  

Thanks for review.

Addressed review comments in patch v03.

 
 * 
{quote}{{testUpdateContainerInvalidMetadata}} - Should we not be allowed to 
update the value for an existing key in containerData#metadata?{quote}When we 
have the same key in the metadata, and when try to add the same key again, we 
are returning error from ContainerData. Actually, in the current code, 
updateContainer and metadata are not used. I think we can change this 
implementation when metadata comes into the picture and according to its use 
case. Let me know if this is okay with you?

 

> Implement KeyValueContainer and adopt new disk layout for the containers
> ------------------------------------------------------------------------
>
>                 Key: HDDS-155
>                 URL: https://issues.apache.org/jira/browse/HDDS-155
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-155-HDDS-48.00.patch, HDDS-155-HDDS-48.01.patch, 
> HDDS-155-HDDS-48.02.patch, HDDS-155-HDDS-48.03.patch
>
>
> This Jira is to add following:
>  # Implement Container Interface
>  # Use new directory layout proposed in the design document.
>  a. Data location (chunks)
>  b. Meta location (DB and .container files)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to