[
https://issues.apache.org/jira/browse/HDFS-13673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511689#comment-16511689
]
Íñigo Goiri commented on HDFS-13673:
------------------------------------
bq. What do you mean to extract the variable? I think this is only used once in
this file?
Just a code style nit to avoid massive one liners:
{code}
File storageDir = new File(dataDir, Storage.STORAGE_DIR_CURRENT);
DataNodeTestUtils.injectDataDirFailure(storageDir);
{code}
> TestNameNodeMetrics fails on Windows
> ------------------------------------
>
> Key: HDFS-13673
> URL: https://issues.apache.org/jira/browse/HDFS-13673
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 3.1.0, 2.9.1
> Reporter: Zuoming Zhang
> Priority: Minor
> Labels: Windows
> Fix For: 3.1.0, 2.9.1
>
> Attachments: HDFS-13673.000.patch,
> TestNameNodeMetrics-testVolumeFailures-Report.000.txt
>
>
> _TestNameNodeMetrics_ fails on Windows
>
> Problem:
> This is because in _testVolumeFailures_, it tries to call
> _DataNodeTestUtils.injectDataDirFailure_ on a volume folder. What
> _injectDataDirFailure_does is actually modifying the folder name from
> _volume_name_ to _volume_name_._origin_ and create a new file named as
> _volume_name_. Inside the folder, it has two things: 1. a directory named as
> "_current_", 2. a file named as "_in_use.lock_". Windows behaves different
> from Linux when renaming the parent folder of a locked file. Windows prevent
> you from renaming while Linux allows.
> Fix:
> So in order to inject data failure on to the volume. Instead of renaming the
> volume folder itself. Rename the folder inside it which doesn't hold a lock.
> Since the folder inside the volume is "_current_". Then we only need to
> inject data failure to _volume_name/current_.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
