[
https://issues.apache.org/jira/browse/HDDS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513572#comment-16513572
]
Mukul Kumar Singh commented on HDDS-141:
----------------------------------------
Thanks for working on this [~shashikant]. The patch looks good to me. Some
really minor comments.
1) ContainerInfo.java:308, "set on this pipeline." it should be container, same
for line 321.
2) Pipeline.java:94, same javadoc comment as earlier can be copied.
3) Pipeline.java:180 & 181, extra lines
4) PipelineManager.java:61, space between pipeline and if
5) PipelineManager.java:147, lets rename conduitsIndex to pipelineIndex
6) RatisManagerImpl.java:70, space between Pipeline and from
7) StandAloneManagerImpl.java:70 , space between Pipeline and from
> Remove PipeLine Class from SCM and move the data field in the Pipeline to
> ContainerInfo
> ---------------------------------------------------------------------------------------
>
> Key: HDDS-141
> URL: https://issues.apache.org/jira/browse/HDDS-141
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Affects Versions: 0.2.1
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-141.00.patch, HDDS-141.01.patch, HDDS-141.02.patch,
> HDDS-141.03.patch
>
>
> Pipeline class currently differs from the pipelineChannel with the data
> field, this field was introduced with HDFS-11118 to maintain per container
> local data. However, this data field can be moved to the ContainerInfo class
> and then the pipelineChannel can be used interchangeably with pipeline
> everywhere. This will help with making code being cleaner.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
