[
https://issues.apache.org/jira/browse/HDDS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514347#comment-16514347
]
Hanisha Koneru commented on HDDS-160:
-------------------------------------
Thanks for the patch [~bharatviswa].
Few minor comments:
# testWriteChunkStageWriteAndCommit -> Can we check that the WRITE_DATA creates
a temporary file and COMMIT_DATA renames it to final file.
# testWriteChunkStageCombinedData -> Line 159-160, COMBINED_DATA doesn’t create
a temporary file.
# testWriteChunkChecksumMismatch -> chunkList is not used.
# testDeleteKey -> after deleteKey, can we versify that the key is deleted by
calling getKey.
> Refactor KeyManager, ChunkManager
> ---------------------------------
>
> Key: HDDS-160
> URL: https://issues.apache.org/jira/browse/HDDS-160
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-160-HDDS-48.01.patch
>
>
> This Jira is to add new Interface ChunkManager and KeyManager to perform Key
> and Chunk related operations.
> # Changes to current existing Keymanager and ChunkManager are:
> ## Removal of usage of ContainerManager.
> ## Passing container to method calls.
> ## Using layOutversion during reading/deleting chunk files.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
