[
https://issues.apache.org/jira/browse/HDFS-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519944#comment-16519944
]
Xiao Chen edited comment on HDFS-13658 at 6/22/18 3:22 AM:
-----------------------------------------------------------
Thanks for revving Kitti. As discussed offline and as you hinted, let's not
change priority queues for this.
bq. Do you think I should keep or remove the integration test?
Given that unit test already covers the scenarios, we can remove the
{{TestOneReplicaBlocksAlert}} test for reduced test execution time. :)
bq. number of the current replicas for decrement
I think we need to modify the call path for from {{BlockManager}}, to get the
current replicas during removal (and handle similarly for decrements coming
from {{update}}, which already has {{curReplicas}}).
{{BlockManager#countNodes}} can do that, and it looks to be O(1).
Also would like to see a test that would confuse the decrements for added
coverage.
was (Author: xiaochen):
Thanks for revving Kitti. As discussed offline and as you hinted, let's not
change priority queues for this.
bq. Do you think I should keep or remove the integration test?
Given that unit test already covers the scenarios, we can remove the
{{TestOneReplicaBlocksAlert}} test for reduced test execution time. :)
bq. number of the current replicas for decrement
I think we need to modify the call path for from {{BlockManager}}, to get the
current replicas during removal (and handle similarly for decrements coming
from {{update}}, which already has {{curReplicas}}).
{{BlockManager#countNodes}} can do that, and it looks to be O(1).
> fsck, dfsadmin -report, and NN WebUI should report number of blocks that have
> 1 replica
> ---------------------------------------------------------------------------------------
>
> Key: HDFS-13658
> URL: https://issues.apache.org/jira/browse/HDFS-13658
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Affects Versions: 3.1.0
> Reporter: Kitti Nanasi
> Assignee: Kitti Nanasi
> Priority: Major
> Attachments: HDFS-13658.001.patch, HDFS-13658.002.patch,
> HDFS-13658.003.patch, HDFS-13658.004.patch, HDFS-13658.005.patch
>
>
> fsck, dfsadmin -report, and NN WebUI should report number of blocks that have
> 1 replica. We have had many cases opened in which a customer has lost a disk
> or a DN losing files/blocks due to the fact that they had blocks with only 1
> replica. We need to make the customer better aware of this situation and that
> they should take action.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
