[
https://issues.apache.org/jira/browse/HDDS-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521316#comment-16521316
]
Bharat Viswanadham commented on HDDS-192:
-----------------------------------------
Hi [~elek]
Thanks for the patch. Overall patch LGTM.
Few comments I have are:
1. ReplicateContainerCommand.java Line 43: extends
SCMCommand<DeleteBlocksCommandProto>. I think here it should be
ReplicateContainerCommandProto.
2. private final ContainerID containerID; Can we use long containerId here?
3. TestReplicateContainerHandler Line 37: * Test to behaviour of the datanode
when recieve replicate container command. Typos in this comment. Can we add
comment like Tests the behavior of the datanode, when replicate container
command is received.
4. TestReplicateContainerHandler Line 56: //send the order to close the
container. This should be send the order to replicate the container.
5. TestReplicateContainerHandler Line 62: Typo in the comment. //TODO: we test
her.
> Create new SCMCommand to request a replication of a container
> -------------------------------------------------------------
>
> Key: HDDS-192
> URL: https://issues.apache.org/jira/browse/HDDS-192
> Project: Hadoop Distributed Data Store
> Issue Type: New Feature
> Components: SCM
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-192.001.patch
>
>
> ReplicationManager needs to request replication/copy of container or deletion
> of container. We have DeleteContainerCommand (a command which is part of the
> datanode heartbeat response) but no command to request a copy of a container.
> This patch adds the command with all the required protobuf
> serialization/deserialization boilerplate to make it easier to review further
> patches.
> No business logic in this patch, but there is a unit test which checks if the
> message is arrived to the datanode site from the scm side.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
