[ 
https://issues.apache.org/jira/browse/HDDS-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521829#comment-16521829
 ] 

Anu Engineer commented on HDDS-191:
-----------------------------------

[~elek] Patch looks very good overall. One minor comment: We should probably 
add a Precondition.checkNotNull before we access values in onMessage. +1 after 
fixing that issue.

> Queue SCMCommands via EventQueue in SCM
> ---------------------------------------
>
>                 Key: HDDS-191
>                 URL: https://issues.apache.org/jira/browse/HDDS-191
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-191.001.patch
>
>
> As a first step towards to a ReplicationManager I propose to introduce the 
> EventQueue to the StorageContainerManager and enable to send SCMCommands via 
> EventQueue.
> With this separation the ReplicationManager could easily send the appropriate 
> SCMCommand (eg. CopyContainer) to the EventQueue without hard dependency to 
> the SCMNodeManager. (And later we can introduce the CommandWatchers without 
> modifying the ReplicationManager part)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to