[
https://issues.apache.org/jira/browse/HDFS-13610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523556#comment-16523556
]
Erik Krogen commented on HDFS-13610:
------------------------------------
Thanks for the comments [~linyiqun]! The patch definitely needed a little
fixing to reflect the changes made during reviews for previous JIRAs. I have
uploaded v001 patch which makes the following changes:
* Remove {{dfs.ha.tail-edits.qjm.rpc.max-txns}} from the documentation
* Remove use of Java 8 lambda API
* Add license header to JournalTestUtil
* Change the name of the new test in {{TestStandbyInProgressTail}} to
{{testEditsServedViaCache}} since it is essentially just confirming that edits
are normally being served via the cache / RPC.
* I left the name of {{testCorruptJournalCache}} as-is. This actually doesn't
fall back to the streaming mechanism; since only one of the two available
JournalNodes is corrupted, it falls back to using the RPC stream from the other
JournalNode. This made me realize I should add a test for the situation you
described; I added {{testTailWithoutCache}} for this.
> [Edit Tail Fast Path Pt 4] Cleanup: integration test, documentation, remove
> unnecessary dummy sync
> --------------------------------------------------------------------------------------------------
>
> Key: HDFS-13610
> URL: https://issues.apache.org/jira/browse/HDFS-13610
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha, journal-node, namenode
> Reporter: Erik Krogen
> Assignee: Erik Krogen
> Priority: Major
> Attachments: HDFS-13610-HDFS-12943.000.patch,
> HDFS-13610-HDFS-12943.001.patch
>
>
> See HDFS-13150 for full design.
> This JIRA is targeted at cleanup tasks:
> * Add in integration testing. We can expand {{TestStandbyInProgressTail}}
> * Documentation in HDFSHighAvailabilityWithQJM
> * Remove the dummy sync added as part of HDFS-10519; it is unnecessary since
> now in-progress tailing does not rely as heavily on the JN committedTxnId
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
