[ 
https://issues.apache.org/jira/browse/HDDS-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523946#comment-16523946
 ] 

Ajay Kumar edited comment on HDDS-175 at 6/26/18 5:15 PM:
----------------------------------------------------------

[~nandakumar131] thanks for review, Patch v7 removes dnList from ContainerInfo 
and SCMContainerInfo.  So some of the refactoring you suggested is not 
applicable. PipelineId in ContainerInfo is renamed to pipelineName to make it 
consistent with Pipeline field. Also removed ClientPbHelper. Will handle 
checkstyle and OzonePBHelper suggestion in next iteration.


was (Author: ajayydv):
[~nandakumar131] thanks for review, Patch v7 removes dnList from ContainerInfo 
and SCMContainerInfo.  So some of the refactoring you suggested is not 
applicable. PipelineId in ContainerInfo is renamed to pipelineName to make it 
consistent with Pipeline field. Also removed ClientPbHelper. Will remove 
OzonePBHelper in next iteration.

> Refactor ContainerInfo to remove Pipeline object from it 
> ---------------------------------------------------------
>
>                 Key: HDDS-175
>                 URL: https://issues.apache.org/jira/browse/HDDS-175
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: SCM
>    Affects Versions: 0.2.1
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-175.00.patch, HDDS-175.01.patch, HDDS-175.02.patch, 
> HDDS-175.03.patch, HDDS-175.04.patch, HDDS-175.05.patch, HDDS-175.06.patch, 
> HDDS-175.07.patch
>
>
> Refactor ContainerInfo to remove Pipeline object from it. We can add below 4 
> fields to ContainerInfo to recreate pipeline if required:
> # pipelineId
> # replication type
> # expected replication count
> # DataNode where its replica exist



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to