[ 
https://issues.apache.org/jira/browse/HDDS-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524564#comment-16524564
 ] 

Xiaoyu Yao commented on HDDS-186:
---------------------------------

Thanks [~ajayydv] for working on this. The patch v2 looks good to me. I just 
have few minor comments:

 

ReplicationQueue.java

Line 41-43: this can be consolidated into a single this.queue.add(repObj).

 

ReplicationReqMsg.java

Line 28: NIT: rename from ReplicationReqMsg -> ReplicationRequest

Line 59: this should be moved before line 56

Line 63: Shorts.compare instead of Long.compare

> Create under replicated queue
> -----------------------------
>
>                 Key: HDDS-186
>                 URL: https://issues.apache.org/jira/browse/HDDS-186
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: SCM
>    Affects Versions: 0.2.1
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-186.00.patch, HDDS-186.01.patch, HDDS-186.02.patch
>
>
> Create under replicated queue to replicate under replicated containers in 
> Ozone.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to