[
https://issues.apache.org/jira/browse/HDFS-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525574#comment-16525574
]
Chao Sun edited comment on HDFS-12976 at 6/27/18 8:28 PM:
----------------------------------------------------------
Thanks for the comments [~xkrogen] and [~shv]!
[~xkrogen]: yes we can potentially use {{stateId}} to achieve the same purpose
- totally agree with you on the concern about adding another flag which
potentially is only used for talking to NameNode.
[~shv]: I like the idea of {{T extends HAServiceProtocol}}, however it may need
more change as {{NameNodeProxiesClient#createProxyWithClientProtocol}} only
create the {{T}} with {{ClientProtocol}}, which may cause exception like:
{code}
Caused by: java.lang.ClassCastException:
org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB cannot be
cast to org.apache.hadoop.ha.HAServiceProtocol
{code}
Sorry I totally forgot about the alignment changes. Thanks for doing that.
Attached the v004 patch after rebasing to the latest HDFS-12943.
was (Author: csun):
Thanks for the comments [~xkrogen] and [~shv]!
[~xkrogen]: yes we can potentially use {{stateId}} to achieve the same purpose
- totally agree with you on the concern about adding another flag which
potentially is only used for talking to NameNode.
[~shv]: I like the idea of {{T extends HAServiceProtocol}}, however it may need
more change as {{NameNodeProxiesClient#createProxyWithClientProtocol}} only
create the {{T}} with {{ClientProtocol}}. Otherwise you may get exception like:
{code}
Caused by: java.lang.ClassCastException:
org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB cannot be
cast to org.apache.hadoop.ha.HAServiceProtocol
{code}
Sorry I totally forgot about the alignment changes. Thanks for doing that.
Attached the v004 patch after rebasing to the latest HDFS-12943.
> Introduce ObserverReadProxyProvider
> -----------------------------------
>
> Key: HDFS-12976
> URL: https://issues.apache.org/jira/browse/HDFS-12976
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Konstantin Shvachko
> Assignee: Chao Sun
> Priority: Major
> Attachments: HDFS-12976-HDFS-12943.000.patch,
> HDFS-12976-HDFS-12943.001.patch, HDFS-12976-HDFS-12943.002.patch,
> HDFS-12976-HDFS-12943.003.patch, HDFS-12976-HDFS-12943.004.patch,
> HDFS-12976-HDFS-12943.005.patch, HDFS-12976.WIP.patch
>
>
> {{StandbyReadProxyProvider}} should implement {{FailoverProxyProvider}}
> interface and be able to submit read requests to ANN and SBN(s).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
