[
https://issues.apache.org/jira/browse/HDDS-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525760#comment-16525760
]
Anu Engineer commented on HDDS-195:
-----------------------------------
Looks good overall. Some minor comments. +1 after fixing them.
* trackedEventsByUUID and trackedEvents can be inconsistent. if and only if,
we have a hashCode for an object which is same.Say someone writes a hashcode as
return 1; we can get into trouble. But, I think it is something that we should
comment rather than solve.
* Perhaps in a different JIRA, we create a leaseManager that can take the
name as a parameter, so we know what these threads are doing when we debug ?
* LeaseManager creates a thread pool per instance, should we have just one
LeaseManager shared by all instances of Watchers ?
* Spurious Edit in HddsDatanodeService.java
> Create generic CommandWatcher utility
> -------------------------------------
>
> Key: HDDS-195
> URL: https://issues.apache.org/jira/browse/HDDS-195
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-195.001.patch, HDDS-195.002.patch,
> HDDS-195.003.patch
>
>
> In some cases we need a class which can track the status of the outgoing
> commands.
> The commands should be resent after a while except a status message is
> received about command completion.
> On high level, we need a builder factory, which takes the following
> parameters:
> * (destination) event type and the payload of the command which should be
> repeated.
> * the ID of the command/event
> * The event/topic of the completion messages. If an IdentifiableEventPayload
> is received on this topic, the specific event is done and don't need to
> resend it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
