[
https://issues.apache.org/jira/browse/HDDS-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526509#comment-16526509
]
Ajay Kumar commented on HDDS-196:
---------------------------------
[~xyao], Thanks for working on it. Patch LGTM. Few minor nits:
* Add javadoc for class ContainerPlacementManager.
* ContainerPlacementManager L20: Do we intentionally want to log via
PipelineSelector? I think we should LOG via ContainerPlacementManager.
* shall we rename ContainerPlacementManager#containerSize (L26) to
defaultContSize/defaultContainerSize ?
* ContainerPlacementManager#createContainerPlacementPolicy L80/82: IMO we
should log error message for other two exceptions as well as its constructor
will fail.
> PipelineManager should choose datanodes based on ContainerPlacementPolicy
> --------------------------------------------------------------------------
>
> Key: HDDS-196
> URL: https://issues.apache.org/jira/browse/HDDS-196
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-196.001.patch
>
>
> This is somehow not connected now after refactoring. This ticket is opened to
> fix it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
