[
https://issues.apache.org/jira/browse/HDDS-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528108#comment-16528108
]
Ajay Kumar commented on HDDS-187:
---------------------------------
[~nandakumar131] thank for review.
1. NPE: You are right, if CommandHandler falls behind, current patch will
remove it from map before processing. I think right thing to do is to not
remove PENDING commands from context map. (i.e if status is FAILED/EXECUTED
then CommandHandler has already processed it)
2. CommandHandlers:Removed stateContext from constructors.
3. Although i have applied checkstyle suggestion but updated code looks more
ugly and brittle. 80 char limit in modern screens doesn't even cover half of
the screen and it makes code more unreadable. In HDDS we have overlooked it on
many instances but i think we should formalize it with some discussions in
community.
> Command status publisher for datanode
> -------------------------------------
>
> Key: HDDS-187
> URL: https://issues.apache.org/jira/browse/HDDS-187
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Affects Versions: 0.2.1
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-187.00.patch, HDDS-187.01.patch
>
>
> Currently SCM sends set of commands for DataNode. DataNode executes them via
> CommandHandler. This jira intends to create a Command status publisher which
> will return status of these commands back to the SCM.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
