[
https://issues.apache.org/jira/browse/HDDS-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530453#comment-16530453
]
Hanisha Koneru commented on HDDS-176:
-------------------------------------
Thanks for working on this, [~bharatviswa].
Patch LGTM overall. Few comments:
# ContainerDataYaml -
** Line 24 : Unused import
** Line 188 : NIT - We can remove the 2nd comment here
# KeyValueContainerData#getYamFields typo in Yaml
# In KeyValueHandler, when creating new containers, the containerMaxSize will
not change unless the service is restarted to pick new config values. So we
could initialize the maxSize into a final static variable when instantiating
HddsDispatcher and reuse that in all Handlers.
{code:java}
int maxSize = conf.getInt(ScmConfigKeys.OZONE_SCM_CONTAINER_SIZE_GB,
ScmConfigKeys.OZONE_SCM_CONTAINER_SIZE_DEFAULT);
{code}
# In, TestKeyValueContainerData and TestContainerDataYaml - Can we put the
const 5 into a static final variable
{code:java}
KeyValueContainerData kvData = new KeyValueContainerData(containerId, 5);
{code}
# When constructing the containerMap by reading the .container file from disk
(KeyValueContainerUtil#parseKeyValueContainerData()), we should update the
keyCount with the number of liveKeys in the DB.
> Add keyCount and container maximum size to ContainerData
> --------------------------------------------------------
>
> Key: HDDS-176
> URL: https://issues.apache.org/jira/browse/HDDS-176
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-176-HDDS-48.00.patch
>
>
> # ContainerData, should hold container maximum size, and this should be
> serialized into .container file. This is needed because after some time,
> container size can be changed. So, old containers will have different max
> size than the newly created containers.
> # And also add KeyCount which says the number of keys in the container.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
