[
https://issues.apache.org/jira/browse/HDDS-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531867#comment-16531867
]
genericqa commented on HDDS-182:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 17 new or modified test
files. {color} |
|| || || || {color:brown} HDDS-48 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
22s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 28m
10s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 28m
43s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
44s{color} | {color:green} HDDS-48 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 22s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-ozone/integration-test {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
51s{color} | {color:red} hadoop-hdds/container-service in HDDS-48 has 4 extant
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
27s{color} | {color:green} HDDS-48 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 28m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 28m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 56s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-ozone/integration-test {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
58s{color} | {color:red} hadoop-hdds/container-service generated 1 new + 2
unchanged - 2 fixed = 3 total (was 4) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
51s{color} | {color:red} hadoop-ozone/tools generated 1 new + 0 unchanged - 0
fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} hadoop-hdds_container-service generated 0 new + 2
unchanged - 3 fixed = 2 total (was 5) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} tools in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} integration-test in the patch passed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 4s{color}
| {color:red} container-service in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
32s{color} | {color:green} tools in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 14m 11s{color}
| {color:red} integration-test in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
41s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}140m 18s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdds/container-service |
| |
org.apache.hadoop.ozone.container.common.impl.ContainerData.getContainerPath()
is unsynchronized,
org.apache.hadoop.ozone.container.common.impl.ContainerData.setContainerPath(String)
is synchronized At ContainerData.java:synchronized At
ContainerData.java:[line 129] |
| FindBugs | module:hadoop-ozone/tools |
| | Dead store to locations in
org.apache.hadoop.ozone.genesis.BenchMarkDatanodeDispatcher.initialize() At
BenchMarkDatanodeDispatcher.java:org.apache.hadoop.ozone.genesis.BenchMarkDatanodeDispatcher.initialize()
At BenchMarkDatanodeDispatcher.java:[line 112] |
| Failed junit tests | hadoop.ozone.container.keyvalue.TestKeyValueContainer |
| | hadoop.ozone.container.common.impl.TestContainerDataYaml |
| | hadoop.ozone.web.client.TestKeysRatis |
| | hadoop.ozone.ksm.TestKSMSQLCli |
| | hadoop.ozone.scm.TestXceiverClientManager |
| | hadoop.ozone.scm.TestContainerSmallFile |
| | hadoop.ozone.freon.TestDataValidate |
| | hadoop.ozone.web.client.TestKeys |
| | hadoop.ozone.client.rpc.TestOzoneRpcClient |
| | hadoop.ozone.container.ozoneimpl.TestOzoneContainer |
| | hadoop.ozone.TestStorageContainerManager |
| | hadoop.ozone.freon.TestFreon |
| |
hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
|
| | hadoop.ozone.ozShell.TestOzoneShell |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | HDDS-182 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12930162/HDDS-182-HDDS-48.001.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 5a14e83607eb 3.13.0-141-generic #190-Ubuntu SMP Fri Jan 19
12:52:38 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDDS-48 / e1f4b3b |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC1 |
| findbugs |
https://builds.apache.org/job/PreCommit-HDDS-Build/425/artifact/out/branch-findbugs-hadoop-hdds_container-service-warnings.html
|
| findbugs |
https://builds.apache.org/job/PreCommit-HDDS-Build/425/artifact/out/new-findbugs-hadoop-hdds_container-service.html
|
| findbugs |
https://builds.apache.org/job/PreCommit-HDDS-Build/425/artifact/out/new-findbugs-hadoop-ozone_tools.html
|
| unit |
https://builds.apache.org/job/PreCommit-HDDS-Build/425/artifact/out/patch-unit-hadoop-hdds_container-service.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HDDS-Build/425/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDDS-Build/425/testReport/ |
| Max. process+thread count | 1011 (vs. ulimit of 10000) |
| modules | C: hadoop-hdds/container-service hadoop-ozone/tools
hadoop-ozone/integration-test U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HDDS-Build/425/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> CleanUp Reimplemented classes
> -----------------------------
>
> Key: HDDS-182
> URL: https://issues.apache.org/jira/browse/HDDS-182
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Attachments: HDDS-182-HDDS-48.001.patch
>
>
> Cleanup container-service's ozone.container.common package. The following
> classes have been refactored and re-implemented. The unused classes/ methods
> should be cleaned up.
> # org.apache.hadoop.ozone.container.common.helpers.ChunkUtils
> # org.apache.hadoop.ozone.container.common.helpers.KeyUtils
> # org.apache.hadoop.ozone.container.common.helpers.ContainerData
> # org.apache.hadoop.ozone.container.common.impl.Dispatcher
> # org.apache.hadoop.ozone.container.common.impl.ChunkManagerImpl
> # org.apache.hadoop.ozone.container.common.impl.KeyManagerImpl
> # org.apache.hadoop.ozone.container.common.impl.ContainerManagerImpl
> # org.apache.hadoop.ozone.container.common.impl.Dispatcher
> Also, fix integration tests broken by deleting these classes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
