[ https://issues.apache.org/jira/browse/HDFS-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532656#comment-16532656 ]
Ewan Higgs commented on HDFS-13310: ----------------------------------- {quote}Can we add javadoc to all the new messages introduced in DatanodeProtocol.proto, and all newly added classes (SyncTask). Any particular reason for static imports in PBHelper.java? If not, I would prefer not declaring these as static imports. {quote} 004 - Add Javadoc - Remove static imports [~virajith] shall I remove PUT_FILE in this ticket or in a followup? > [PROVIDED Phase 2] The DatanodeProtocol should be have DNA_BACKUP to backup > blocks > ---------------------------------------------------------------------------------- > > Key: HDFS-13310 > URL: https://issues.apache.org/jira/browse/HDFS-13310 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Ewan Higgs > Assignee: Ewan Higgs > Priority: Major > Attachments: HDFS-13310-HDFS-12090.001.patch, > HDFS-13310-HDFS-12090.002.patch, HDFS-13310-HDFS-12090.003.patch, > HDFS-13310-HDFS-12090.004.patch > > > As part of HDFS-12090, Datanodes should be able to receive DatanodeCommands > in the heartbeat response that instructs it to backup a block. > This should take the form of two sub commands: PUT_FILE (when the file is <=1 > block in size) and MULTIPART_PUT_PART when part of a Multipart Upload (see > HDFS-13186). -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org