[ 
https://issues.apache.org/jira/browse/HDFS-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo (Nicholas), SZE updated HDFS-2112:
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.23.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

> ... we used google's VisibleForTesting annotation tag. ...

Since we do not indeed use the tag in our test framework, adding it to some 
methods is useless.  Someone later may add some other tags from other library 
and then it becomes very confusing.  A javadoc comment is better.

+1 patch look good.

I have committed this.  Thanks, Uma!

> Move ReplicationMonitor to block management
> -------------------------------------------
>
>                 Key: HDFS-2112
>                 URL: https://issues.apache.org/jira/browse/HDFS-2112
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Uma Maheswara Rao G
>             Fix For: 0.23.0
>
>         Attachments: HDFS-2112.1.patch, HDFS-2112.patch
>
>
> Replication should be handled by block manager instead of name system. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to