[
https://issues.apache.org/jira/browse/HDDS-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533996#comment-16533996
]
Xiaoyu Yao commented on HDDS-217:
---------------------------------
Thanks [~anu] for the patch. The change looks good to me. I just have two minor
comments
SCMEvents.java
Line 71: should we rename CLOSE_CONTAINER_EVENT to CLOSE_CONTAINER to be
consistent with other events defined in SCMEvents class?
TestCloseContainerEventHandler.java
Line 56: suggest using RandmomUtil.nextInt to avoid the hassle of maintaining
member variable rand.
> Move all SCMEvents to a package
> -------------------------------
>
> Key: HDDS-217
> URL: https://issues.apache.org/jira/browse/HDDS-217
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-217.001.patch
>
>
> Moving all SCM internal events to a single package; then it is easy to write
> event producers and consumers easily. Also, we have a single location for all
> the events. This patch is a simple refactoring patch.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
