[
https://issues.apache.org/jira/browse/HDDS-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536374#comment-16536374
]
Anu Engineer commented on HDDS-207:
-----------------------------------
[~ljain] Thanks for the patch. One quick question: if we give a null argument
or an empty URI, we will fail the command. But if we give some nonsense string,
we will recover and use sane defaults. That seems like a very inconsistent user
experience.
I would have expected either the
*./ozone oz -*listVolume
*./ozone oz -listVolume abcde*
both work, but the second one issue a warning that it is ignoring the arg. Or
both fail with the right error message that a valid URI to ozone Manager is
required.
> ozone listVolume command accepts random values as argument
> ----------------------------------------------------------
>
> Key: HDDS-207
> URL: https://issues.apache.org/jira/browse/HDDS-207
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Client
> Reporter: Nilotpal Nandi
> Assignee: Lokesh Jain
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-207.001.patch
>
>
> When no argument from listVolume is provided, it complains.
> But a random argument is provided for listVolume command, it accepts and
> displays all the volumes.
> {noformat}
> [root@ozone-vm bin]# ./ozone oz -listVolume
> Missing argument for option: listVolumeERROR: null
> [root@ozone-vm bin]# ./ozone oz -listVolume abcdefghijk
> 2018-06-29 07:09:43,451 WARN util.NativeCodeLoader: Unable to load
> native-hadoop library for your platform... using builtin-java classes where
> applicable
> [ {
> "owner" : {
> "name" : "root"
> },
> "quota" : {
> "unit" : "TB",
> "size" : 1048576
> },
> "volumeName" : "nnvolume1",
> "createdOn" : "Sun, 18 Sep +50444 15:12:11 GMT",
> "createdBy" : "root"
> }, {
> "owner" : {
> "name" : "root"
> },
> "quota" : {
> "unit" : "TB",
> "size" : 1048576
> },
> "volumeName" : "nnvolume2",
> "createdOn" : "Tue, 27 Sep +50444 13:05:43 GMT",
> "createdBy" : "root"
> } ]
> {noformat}
> expectation:
> It should not accept random values as argument
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
