[
https://issues.apache.org/jira/browse/HDDS-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536390#comment-16536390
]
Anu Engineer commented on HDDS-224:
-----------------------------------
I am +1 on this patch. Because of all the hidden classes etc. it is very
difficult to understand what is happening in the TestEventWatcher, I had to run
them in a debugger (which causes the timeout asserts to fail :() could please
comment in detail why these asserts work as they do?
{noformat}
Assert.assertEquals(3, metrics.getTrackedEvents().value());
Assert.assertEquals(1, metrics.getCompletedEvents().value());
Assert.assertEquals(2, metrics.getTimedOutEvents().value());
{noformat}
> Create metrics for Event Watcher
> --------------------------------
>
> Key: HDDS-224
> URL: https://issues.apache.org/jira/browse/HDDS-224
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-224.001.patch, HDDS-224.002.patch
>
>
> EventWatcher is a common way to track the state of the on-going commands. To
> make it easier to track the current in-flight commands and the average
> message processing times the messages should be monitored by Hadoop metrics.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
