[
https://issues.apache.org/jira/browse/HDFS-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537636#comment-16537636
]
Virajith Jalaparti commented on HDFS-13421:
-------------------------------------------
Thanks for posting the patch [~ehiggs]. A few questions:
- What's the purpose of \{{DFS_PROVIDED_HEARTBEAT_BACKUP_NUM}}?
- You don't need to initialize \{{executorService}} in both the constructor of
\{{SyncServiceSatisfierDatanodeWorker}} and
\{{SyncServiceSatisfierDatanodeWorker#start()}}, right?
- In \{{BlockSyncOperationExecutor#doMultiPartPart}}, each block is copied into
memory and then written to the external store. This can lead to an
OutOfMemoryError. A related question -- shouldn't each LocatedBlock be
associated with one putPart? The current implementation concats all the blocks
in a BlockSyncTask as a single part in a multi-part upload.
- Can we finish integrating the SyncServiceSatisfierDatanodeWorker with the
heartbeat/DN commands in this sub-task (and add appropriate test cases)?
> [PROVIDED Phase 2] Implement DNA_BACKUP command in Datanode
> -----------------------------------------------------------
>
> Key: HDFS-13421
> URL: https://issues.apache.org/jira/browse/HDFS-13421
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Ewan Higgs
> Assignee: Ewan Higgs
> Priority: Major
> Attachments: HDFS-13421-HDFS-12090.001.patch,
> HDFS-13421-HDFS-12090.002.patch, HDFS-13421-HDFS-12090.003.patch
>
>
> HDFS-13310 introduces an API for DNA_BACKUP. Here, we implement DNA_BACKUP
> command in Datanode.
> These have been broken up to make reviewing it easier.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
