[ 
https://issues.apache.org/jira/browse/HDFS-13583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539955#comment-16539955
 ] 

Dibyendu Karmakar commented on HDFS-13583:
------------------------------------------

Hi, [~linyiqun] regarding your comment on TestRouterAdminCLI and 
TestRouterAdmin, in this two test classes some of the test cases which are 
related to updating mount table will fail if we use fake nameservice. 

Now, every updateMountTableEntry call will go to synchronizeQuota and there we 
are checking whether the directory is present in the filesystem.  
{code:java}
private void synchronizeQuota(MountTable mountTable) throws IOException {
    String path = mountTable.getSourcePath();
    long nsQuota = mountTable.getQuota().getQuota();
    long ssQuota = mountTable.getQuota().getSpaceQuota();

    if (nsQuota != HdfsConstants.QUOTA_DONT_SET
        || ssQuota != HdfsConstants.QUOTA_DONT_SET) {
      HdfsFileStatus ret = this.router.getRpcServer().getFileInfo(path);
      if (ret != null) {
        this.router.getRpcServer().getQuotaModule().setQuota(path, nsQuota,
            ssQuota, null);
      }
    }
  }
{code}
for fake nameservice getFileInfo call will fail. That's why I was starting the 
cluster.

I am not aware if we can do this with fake nameservice. Do you have any 
suggestion?

 

The changes in TestRouterAdmin is also related to this patch only, in 
testEditMountTable test case we were using "/" root dir as the target dir, so 
during synchronizeQuota namenode will throw "Cannot clear namespace quota on 
root."

 

> RBF: Router admin clrQuota is not synchronized with nameservice
> ---------------------------------------------------------------
>
>                 Key: HDFS-13583
>                 URL: https://issues.apache.org/jira/browse/HDFS-13583
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Dibyendu Karmakar
>            Assignee: Dibyendu Karmakar
>            Priority: Major
>         Attachments: HDFS-13583-000.patch, HDFS-13583-001.patch, 
> HDFS-13583-branch-2-001.patch
>
>
> Router admin -clrQuota command is removing the quota from the mount table 
> only, it is not getting synchronized with nameservice.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to