[ 
https://issues.apache.org/jira/browse/HDDS-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543569#comment-16543569
 ] 

Bharat Viswanadham commented on HDDS-251:
-----------------------------------------

Hi [~ljain]

Over all patch LGTM. I have a few minor comments.
1. Can we change the name of 
ozone.scm.key.value.container.deletion-choosing.policy to 
ozone.scm.keyvalue.container.deletion-choosing.policy.
2. I think we need to add that property to ozone-default.xml
3. We can remove this // TODO: Implement BlockDeletingService in 
ContainerSet.java.

> Integrate BlockDeletingService in KeyValueHandler
> -------------------------------------------------
>
>                 Key: HDDS-251
>                 URL: https://issues.apache.org/jira/browse/HDDS-251
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Ozone Datanode
>            Reporter: Lokesh Jain
>            Assignee: Lokesh Jain
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-251.001.patch, HDDS-251.002.patch
>
>
> This Jira aims to integrate BlockDeletingService in KeyValueHandler. It also 
> fixes the unit tests related to delete blocks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to