[ https://issues.apache.org/jira/browse/HDDS-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543583#comment-16543583 ]
Xiaoyu Yao edited comment on HDDS-207 at 7/13/18 6:41 PM: ---------------------------------------------------------- Thanks [~ljain] for reporting and working on this. It is OK to resort default URI when not specified in -listVolume command. But when you specify a parameter, it is should be a correct URI. I would like we fail consistently for the following cases. # -listVolume "abcd", warn but get list of volumes from default uri # -listVolume "http://xxx", failed # -listVolume "o3://invalid" failed. was (Author: xyao): Thanks [~ljain] for reporting and working on this. It is OK to resort default URI when not specified in -listVolume command. But when you specify a parameter, it is should be a correct URI. I would like we fail consistently for the following cases. # -listVolume "abcd", warn but get list of volumes from default uri # -listVolume "http://xxx/yyy", failed # -listVolume "o3://invalid" failed. Can you also check the listBucket/listKey CLI to see if we have similar problem with the URI parameter handling? > ozone listVolume command accepts random values as argument > ---------------------------------------------------------- > > Key: HDDS-207 > URL: https://issues.apache.org/jira/browse/HDDS-207 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Client > Reporter: Nilotpal Nandi > Assignee: Lokesh Jain > Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-207.001.patch, HDDS-207.002.patch > > > When no argument from listVolume is provided, it complains. > But a random argument is provided for listVolume command, it accepts and > displays all the volumes. > {noformat} > [root@ozone-vm bin]# ./ozone oz -listVolume > Missing argument for option: listVolumeERROR: null > [root@ozone-vm bin]# ./ozone oz -listVolume abcdefghijk > 2018-06-29 07:09:43,451 WARN util.NativeCodeLoader: Unable to load > native-hadoop library for your platform... using builtin-java classes where > applicable > [ { > "owner" : { > "name" : "root" > }, > "quota" : { > "unit" : "TB", > "size" : 1048576 > }, > "volumeName" : "nnvolume1", > "createdOn" : "Sun, 18 Sep +50444 15:12:11 GMT", > "createdBy" : "root" > }, { > "owner" : { > "name" : "root" > }, > "quota" : { > "unit" : "TB", > "size" : 1048576 > }, > "volumeName" : "nnvolume2", > "createdOn" : "Tue, 27 Sep +50444 13:05:43 GMT", > "createdBy" : "root" > } ] > {noformat} > expectation: > It should not accept random values as argument -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org