[
https://issues.apache.org/jira/browse/HDFS-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070970#comment-13070970
]
Suresh Srinivas commented on HDFS-2191:
---------------------------------------
Comments:
# Is this correct? {{10000 * heartbeatIntervalSeconds}} Why 10000? Should you
be multiplying it by 1000 when getting it from conf and not 10000 *?
# blockManager.getDatanodeManager().getDatanode() - we could add a method
blockManager.getDataNode() - I prefer this instead of exposing DatanodeManager
to FSNamesystem.
# Earlier getDatanode() used to lock using datanodeMap, do we need that with
your patch? How is it synchronized now? Also datanodeMap access may not be
synchronized correctly - for example datanodeDump synchronizes it but other
instances such as DatanodeManager#getDatanode() does not.
# In a future patch FSNamesystem#heartbeats and its synchronization should move
to blockmanager
# Please change javadoc of getDatanode() as throws UnregisteredNodeException.
# I am sure you have already planned for removing
FSNamesystem#blockInvalidateLimit in future patch.
# How is DatanodeManager#getDatanodeCyclicIteration() synchronized? It cannot
be synchronized using FSNamesystem.writeLock() as done currently?
> Move datanodeMap from FSNamesystem to DatanodeManager
> -----------------------------------------------------
>
> Key: HDFS-2191
> URL: https://issues.apache.org/jira/browse/HDFS-2191
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h2191_20110723.patch, h2191_20110723b.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
