[
https://issues.apache.org/jira/browse/HDFS-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546859#comment-16546859
]
Erik Krogen commented on HDFS-13523:
------------------------------------
Thanks for working on this [~zhengxg3]! A few comments:
* Can we just add a new test case in {{TestMiniDFSCluster}} instead of an
entirely new test class? The name of the class is currently misleading, as it
isn't actually testing the observer node, it is testing the MiniDFSCluster.
* Please don't use star-imports.
* When you change {{operation}}, all subsequent NameNodes will be affected as
well since this variable is used by all of them. You probably need to create a
new local variable.
> Support observer nodes in MiniDFSCluster
> ----------------------------------------
>
> Key: HDFS-13523
> URL: https://issues.apache.org/jira/browse/HDFS-13523
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode, test
> Reporter: Erik Krogen
> Assignee: Sherwood Zheng
> Priority: Major
> Attachments: HADOOP-13523-HADOOP-12943.000.patch,
> HADOOP-13523-HADOOP-12943.001.patch, HDFS-13523-HDFS-12943.001.patch
>
>
> MiniDFSCluster should support Observer nodes so that we can write decent
> integration tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
