[
https://issues.apache.org/jira/browse/HDFS-13743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550157#comment-16550157
]
Yiqun Lin edited comment on HDFS-13743 at 7/20/18 3:16 AM:
-----------------------------------------------------------
The latest patch almost looks good, one minor comment:
Would you mind adding following log in {{if (defaultNameService == null)
{...}}}? It will let us know which config is real be used.
{noformat}
LOG.warn("{} and {} is not set. Fallback to {} as the default name service.",
DFS_ROUTER_DEFAULT_NAMESERVICE, DFS_NAMESERVICE_ID, DFS_NAMESERVICES);
{noformat}
Other looks good to me.
One more question from me: what will be happening if we return empty string
(not null) as the default service? [~tasanuma0829], would you mind doing a
verification as you mentioned in description?
was (Author: linyiqun):
The latest patch almost looks good, one minor comment:
Would you mind adding following log in {{if (defaultNameService == null)
{...}}}? It will let us know which config is real be used.
{noformat}
LOG.warn("{} and {} is not set. Fallback to {} as the default name service.",
DFS_ROUTER_DEFAULT_NAMESERVICE, DFS_NAMESERVICE_ID, DFS_NAMESERVICES);
{noformat}
Other looks good to me.
> RBF: Router throws NullPointerException due to the invalid initialization of
> MountTableResolver
> -----------------------------------------------------------------------------------------------
>
> Key: HDFS-13743
> URL: https://issues.apache.org/jira/browse/HDFS-13743
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Takanobu Asanuma
> Assignee: Takanobu Asanuma
> Priority: Major
> Attachments: HDFS-13743.1.patch, HDFS-13743.2.patch,
> HDFS-13743.3.patch, HDFS-13743.4.patch
>
>
> When {{dfs.federation.router.default.nameserviceId}} isn't set and any other
> default name service isn't found, clients can't submit requests to the router
> because of {{NullPointerException}}.
> # client side
> {noformat}
> $ hadoop fs -ls hdfs://router:8888/
> ls: java.lang.NullPointerException
> {noformat}
> # Router log
> {noformat}
> java.lang.NullPointerException
> at java.util.TreeMap.getEntry(TreeMap.java:347)
> at java.util.TreeMap.containsKey(TreeMap.java:232)
> at java.util.TreeSet.contains(TreeSet.java:234)
> at
> org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer.getLocationsForPath(RouterRpcServer.java:2287)
> at
> org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer.getLocationsForPath(RouterRpcServer.java:2239)
> at
> org.apache.hadoop.hdfs.server.federation.router.RouterRpcServer.getFileInfo(RouterRpcServer.java:1163)
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.getFileInfo(ClientNamenodeProtocolServerSideTranslatorPB.java:966)
> at
> org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:524)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1025)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:876)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:822)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1689)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2682)
> {noformat}
> The cause of this error is that the initialization of {{MountTableResolver}}
> doesn't work properly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
