[
https://issues.apache.org/jira/browse/HDDS-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551144#comment-16551144
]
Mukul Kumar Singh commented on HDDS-181:
----------------------------------------
Thanks for the updated patch [~shashikant]. Please find my updated comments as
following.
1) I feel that OpenContainerBlockMap can be initialized inside the
KeyValueContainer. As this is a per container type property.
2) KeyValueHandler.java:378, the comment can be re-phrased to "remove the
container from open block map once, all the blocks have been committed and the
container is closed"
3) KeyValueHandler.java:411, lets move the commit key before we update the
counter at 409.
4) KeyValueHandler.java:426, NIT: pendinKeys -> pendingKeys.
5) KeyValueHandler.java:491, I feel this is not required. If a block has not
been comitted, then the client is never call deleteblock for the block. At this
time, the entries in the container if any are present are garbage. Lets raise a
jira to deal with this garbage later.
6) OpenContainerBlockMap.java, removeContainer and removeContainerFromKeyMap
are both removing the container. Please remove of these functions. Also in
removeFromKeyMap, the call to remove the container, can call one of these
functions to remove the final container.
> CloseContainer should commit all pending open Keys on a datanode
> ----------------------------------------------------------------
>
> Key: HDDS-181
> URL: https://issues.apache.org/jira/browse/HDDS-181
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-181.01.patch, HDDS-181.02.patch, HDDS-181.03.patch,
> HDDS-181.04.patch
>
>
> A close container command arrives in the Datanode by the SCM heartBeat
> response.It will then be queued up over the ratis pipeline. Once the command
> execution starts inside the Datanode, it will mark the container in CLOSING
> State. All the pending open keys for the container now will be committed
> followed by the transition of the container state from CLOSING to CLOSED. For
> achieving this, all the open keys for a container need to be tracked.
> This Jira aims to address this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
