[
https://issues.apache.org/jira/browse/HDDS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551428#comment-16551428
]
Bharat Viswanadham commented on HDDS-266:
-----------------------------------------
Hi [~hanishakoneru]
Thanks for the patch. Overall patch Looks good to me.
*Few minor comments:*
1. ContainerDataYaml.java
private static final Logger LOG = LoggerFactory.getLogger(Container.class); Why
here Container class is added?
2. Can we move the verifyCheckSum in ContainerDataYaml to ContainerUtils.java.
We can keep ContainerDataYaml
for yaml related code, read and write container files.
3. Can we add javadoc for newly added methods in ContainerDataYaml.java
4. Unnecessary check of Preconditions.checkNotNull in getContainerFile and
getContainerDBFile in KeyValueContainerLocationUtil.java
5. KeyValueContainerUtil.java: Line 177,181: Instead of
kvContainerData.getContainerID(), we can use ContainerId from Line 164.
6. KeyValueContainerUtil.java: Line 161: First parameter can fit in the first
line of the method.
7. TestContainerDataYaml.java, path is already defined as a member variable, so
there is a checkstyle issue of hidden field. As it is again defined inside the
methods. Can we rename it to make checkstyle happy?
> Integrate checksum into .container file
> ---------------------------------------
>
> Key: HDDS-266
> URL: https://issues.apache.org/jira/browse/HDDS-266
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-266.001.patch, HDDS-266.002.patch
>
>
> Currently, each container metadata has 2 files - .container and .checksum
> file.
> In this Jira, we propose to integrate the checksum into the .container file
> itself. This will help with synchronization during container updates.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
