[
https://issues.apache.org/jira/browse/HDFS-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071343#comment-13071343
]
Hadoop QA commented on HDFS-2201:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12487837/HDFS-2201.patch
against trunk revision 1150960.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestHDFSCLI
org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery
org.apache.hadoop.hdfs.server.namenode.TestBlocksWithNotEnoughRacks
org.apache.hadoop.hdfs.server.namenode.TestBlockTokenWithDFS
org.apache.hadoop.hdfs.server.namenode.TestCorruptFilesJsp
org.apache.hadoop.hdfs.server.namenode.TestFsck
org.apache.hadoop.hdfs.server.namenode.TestNodeCount
org.apache.hadoop.hdfs.server.namenode.TestOverReplicatedBlocks
org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery
org.apache.hadoop.hdfs.TestCrcCorruption
org.apache.hadoop.hdfs.TestDatanodeBlockScanner
org.apache.hadoop.hdfs.TestDataTransferProtocol
org.apache.hadoop.hdfs.TestDFSClientRetries
org.apache.hadoop.hdfs.TestFileAppend3
org.apache.hadoop.hdfs.TestMissingBlocksAlert
org.apache.hadoop.hdfs.TestParallelRead
org.apache.hadoop.hdfs.TestPread
org.apache.hadoop.hdfs.TestReplication
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1025//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/1025//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1025//console
This message is automatically generated.
> combine sequence read and position read
> ---------------------------------------
>
> Key: HDFS-2201
> URL: https://issues.apache.org/jira/browse/HDFS-2201
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: John George
> Assignee: John George
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-2201.patch
>
>
> It might be beneficial (especially from maintenance pov) to combine the logic
> of sequence and position read calls in DFSInputStream.java.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
