[ 
https://issues.apache.org/jira/browse/HDDS-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553433#comment-16553433
 ] 

Xiaoyu Yao commented on HDDS-262:
---------------------------------

Thanks [~bharatviswa] for the patch. Patch v2 looks good to me. I just have one 
minor suggestion:

TestVolumeSet.java

Line 245-246: can we wrap this in the try{} final{} so that the readonly test 
dir are cleaned up after the test?

+1 after that being fixed.

> Send SCM healthy and failed volumes in the heartbeat
> ----------------------------------------------------
>
>                 Key: HDDS-262
>                 URL: https://issues.apache.org/jira/browse/HDDS-262
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-262.00.patch, HDDS-262.01.patch, HDDS-262.02.patch
>
>
> The current code only sends volumes which are successfully created during 
> datanode startup. For any volume an error occurred during HddsVolume object 
> creation, we should move that volume to failedVolume Map. This should be sent 
> to SCM as part of NodeReports.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to