[
https://issues.apache.org/jira/browse/HDDS-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553643#comment-16553643
]
Xiaoyu Yao commented on HDDS-282:
---------------------------------
Thanks [~elek] for fixing this, +1 for the v1 patch. I will commit it shortly.
> Consolidate logging in scm/container-service
> ---------------------------------------------
>
> Key: HDDS-282
> URL: https://issues.apache.org/jira/browse/HDDS-282
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-282.001.patch
>
>
> During real cluster tests, I found some logging/error handling very annoying.
> I propose to improve the following behaviour:
> # In case of datanode-> scm communication failure we don't log the
> exception. As there (EndpointStateMachine.java:L206). As the messages have
> already been throttled I think it's safe to log the exception.
> # In BlockDeletingServlce:L123, I would log the message (Plan to choose {}
> containers for block deletion, actually returns {} valid containers) only if
> the number of valid containers is greater than 0.
> # EventQueue could log a warning if handlers is missing for a message
> (instead of an exception)
> # TypedEvent should have a toString method (as it's used in the EventQueue
> logging).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
