[ 
https://issues.apache.org/jira/browse/HDDS-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553997#comment-16553997
 ] 

Nanda kumar commented on HDDS-285:
----------------------------------

Thanks [~bharatviswa] for working on this. The patch looks pretty good to me, 
some minor comments

MetaStoreIterator: '{{interface MetaStoreIterator<T> extends Iterator'}} should 
be '{{interface MetaStoreIterator<T> extends Iterator<T>'}}

LevelDBStoreIterator#next & RocksDBStoreIterator#next: We should throw 
{{NoSuchElementException}} if the iteration has no more elements. Current patch 
returns null.

MetadataStore: Rename suggestion - {{newIterator}} -> {{iterator}}

> Create a generic Metadata Iterator
> ----------------------------------
>
>                 Key: HDDS-285
>                 URL: https://issues.apache.org/jira/browse/HDDS-285
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-285.00.patch, HDDS-285.01.patch
>
>
> This Jira is to track the work to have a wrapper class Iterator for 
> MetadataStore and use that iterator during iterating db.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to