[
https://issues.apache.org/jira/browse/HDDS-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554093#comment-16554093
]
Nanda kumar commented on HDDS-277:
----------------------------------
Thanks [~msingh] for working on this. The patch looks pretty good to me.
*CloseContainerEventHandler*
Line:24 Unused import
Line:66 & 71: Not related to this patch, the log level should be either ERROR
or WARN
*ContainerMapping*
Line:108 Instead of adding {{EventQueue}} as a constructor argument, we can use
{{EventPublisher }}reference.
{{updateContainerState}}: {{updatedContainer.isContainerOpen()}} will return
false if the container is in {{CLOSING}} state. At this point we should not
close the pipeline as we might still need to send close container command to
the datanodes.
*ContainerStateMap*
Containers should not be removed from {{openPipelineMap}} if they are in
{{CLOSING}} state. Only when updated to {{CLOSED}} state we can remove the
container from {{openPipelineMap}}.
*Node2PipelineMap*
Line:113 & 122: Checkstyle: ',' is not followed by whitespace
*TestPipelineClose*
Line:36 & 38 Unused import
Line:24, 40 & 41 Line length
It is good to add one more test-case to verify the pipeline is not closed even
after we do close pipeline, unless all the containers on the pipeline are
closed. The last container close should also close the pipeline.
> PipelineStateMachine should handle closure of pipelines in SCM
> --------------------------------------------------------------
>
> Key: HDDS-277
> URL: https://issues.apache.org/jira/browse/HDDS-277
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Affects Versions: 0.2.1
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-277.001.patch
>
>
> Currently the only visible state of pipelines in SCM is the open state. This
> jira adds capability to PipelineStateMachine to close a SCM pipeline and
> corresponding open containers on the pipeline. Once all the containers on the
> pipeline have been closed then the nodes of the pipeline will be released
> back to the free node pool
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
